Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize abstract filters #10

Open
jamgochiana opened this issue Aug 31, 2019 · 1 comment
Open

Parameterize abstract filters #10

jamgochiana opened this issue Aug 31, 2019 · 1 comment

Comments

@jamgochiana
Copy link
Collaborator

function predict(b0::GaussianBelief, u::Vector{a},
filter::ExtendedKalmanFilter) where a<:Number
# Motion update
# Linear motion
if filter.d isa LinearDynamicsModel

ExtendedKalmanFilter should be parameterized by DynamicsModel and ObservationModel types.

@zsunberg
Copy link
Member

Parameterizing by the DynamicsModel and ObservationModel types will indeed yield significant performance improvement, but these parameters need not be present in function signatures, for example:

 function predict(b0::GaussianBelief, u::AbstractVector, filter::ExtendedKalmanFilter)

will have identical performance to

 function predict(b0::GaussianBelief, u::Vector{a}, filter::ExtendedKalmanFilter) where a<:Number

as you have now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants