Skip to content
This repository has been archived by the owner on Dec 18, 2020. It is now read-only.

Major 2.0 Refactoring #5

Open
13 of 18 tasks
alikindsys opened this issue Jul 16, 2020 · 0 comments
Open
13 of 18 tasks

Major 2.0 Refactoring #5

alikindsys opened this issue Jul 16, 2020 · 0 comments
Labels
2.0 HOLD This issue is on hold since it depends on another issue List WIP

Comments

@alikindsys
Copy link
Member

⚠️ = Depends on : feature:interactivity.

Todo

Systems [Moved to #17]

  • Permanent disabling behaviour to systems.
  • Permament disabling functionality to the system disable command
  • setmaster command utilize RequireSystemAttribute since mastersystem can be disabled.
  • Display permanently disabled systems on system list command

Configuration Overhaul ⚠️

  • Add IConfig interface ⚠️
  • Port using configuration files to use new IConfig interface ⚠️
  • Disableable commands ⚠️
  • Disableable systems
  • Toggleable dsp internal logger ⚠️

Logger

  • Move newline to EOL for dsp logger compatibility

API Changes ⚠️

  • void -> Task on IApplyToClient ⚠️

QOL ⚠️

  • sensible indentation ⚠️
  • Remove testbed system
  • Use .WhenCanceled instead of while on SisbaseBot
  • Convert Aggregate queries to string.Join
  • Use preconditions whenever possible ⚠️
  • Replace nested foreach with linq queries whenever possible ⚠️
  • Update dsp version to latest
@alikindsys alikindsys added this to the "Kohinata Nanoka" 2.0 milestone Jul 16, 2020
@alikindsys alikindsys pinned this issue Jul 16, 2020
@alikindsys alikindsys added the WIP label Jul 16, 2020
@alikindsys alikindsys changed the title Remaking all refactoring/kohinata-nanoka features Major 2.0 Refactoring Aug 1, 2020
@alikindsys alikindsys unpinned this issue Aug 1, 2020
@alikindsys alikindsys added the HOLD This issue is on hold since it depends on another issue label Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.0 HOLD This issue is on hold since it depends on another issue List WIP
Projects
None yet
Development

No branches or pull requests

1 participant