Skip to content
This repository has been archived by the owner on Dec 18, 2020. It is now read-only.

Ambiguous references on the sisbase.Utils namespace #31

Open
alikindsys opened this issue Jul 20, 2020 · 3 comments
Open

Ambiguous references on the sisbase.Utils namespace #31

alikindsys opened this issue Jul 20, 2020 · 3 comments
Labels
2.0 API Design BUG! HOLD This issue is on hold since it depends on another issue Refactoring

Comments

@alikindsys
Copy link
Member

Workaround

Explicitly declare DSharpPlus.Permissions

Proposed Solution

Rename sisbase.Utils.Permissions to avoid the conflict.

@wffirilat
Copy link
Member

Suggested name: sisbase.Utils.PermissionUtils. Permissions is a static class with helper methods, and these can conventionally be postfixed with Utils

@alikindsys
Copy link
Member Author

alikindsys commented Jul 20, 2020

Then its better to find all the classes that match that condition and apply the rename. Pretty sure theres more then just one.

@alikindsys alikindsys changed the title 'Permissions' is an ambiguous reference between 'DSharpPlus.Permissions' and 'sisbase.Utils.Permissions' Ambiguous references on the sisbase.Utils namespace Jul 20, 2020
@wffirilat
Copy link
Member

Agreed. The only other file in Utils that matches this pattern is Unicode, which contains a list of unicode emojis. It does not (currently) provide any functions abstractig over the usage of this list, only two dictionaries Emojis: Disctionary<string, string> (really <UnicodePoint, DiscordName>) and UnicodeEmojisByDiscordName (really Dictionary<DiscordName, UnicodePoint>). these aren't self explanatory, so perhaps split that rename and refactoring into a different issue

@alikindsys alikindsys added this to the "Kohinata Nanoka" 2.0 milestone Jul 20, 2020
@alikindsys alikindsys added the HOLD This issue is on hold since it depends on another issue label Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.0 API Design BUG! HOLD This issue is on hold since it depends on another issue Refactoring
Projects
None yet
Development

No branches or pull requests

2 participants