ColorPicker registerForRefresh behavior

[sirinsidiator]

circonian wrote:

If a panel is set to refresh, registerForRefresh= true, the colorPicker fires the setFunc non-stop as the colors are changed, even though the user has not clicked "Accept" to set the color.

If they click "Accept" nothing happens, setFunc does not fire. Which I guess is ok since setFunc was firing as we were changing the colorPicker.
If the user clicks "Cancel" it does fire the setFunc one more time passing it the original color to reset it, although if you hit "Esc" the color gets changed (setFunc was firing as you were changing colors) & it does not fire that final setFunc to revert the color back to the original color because the user did not click "Cancel".

I know its set to register for refresh, but the user hasn't actually changed the color yet. Should setFunc even be firing as the colorPicker changes values? In some ways its nice to see the colors changing as you drag the color picker around, but it also fires setFunc a lot. The slider does not function that way. It doesn't fire setFunc until you stop dragging the slider (which is kind of like clicking accept).

I guess it's not really a huge deal, and may be intentional (except that ESC key thing), but either way I just thought I would let you know.

[sirinsidiator]

The behavior is caused by the ingame color picker dialog. It's something that needs to be fixed in the client. The set function being called continuously is something that may be worth a config entry on the table, so it can be disabled.

[A-312]

Did you find a fix ?

[sirinsidiator]

I fixed the color picker bugs in Medic - UI Fixes as it is not really an issue with LAM itself. I have also reported them, but I don't think they have a high priority.

As for the set callback being called before the color is accepted, I am thinking of splitting it into 2 separate functions, so one is called for preview purposes and the other for actually setting the selected color, but it may require a major update as it would break addons that rely on that behavior.