New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistake in malleability type table for `thresh` #127

Open

benma opened this issue Jan 9, 2023 · 0 comments

Contributor

benma commented Jan 9, 2023

The malleability type properties for thresh on the website state:

s=at most k-1 are non-s; e=all are s

for e it should say e=all are e and all are s. The code implements it like this too:

miniscript/bitcoin/script/miniscript.cpp

Line 241 in 484386a

"e"_mst.If(all_e && num_s == n_subs) | // e=all e and all s

The text was updated successfully, but these errors were encountered:

benma changed the title ~~Mistake in malleability type table mistake for thresh~~ Mistake in malleability type table for thresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment