Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export types from /server entrypoint #214

Open
rdsfj opened this issue Nov 26, 2024 · 0 comments
Open

Export types from /server entrypoint #214

rdsfj opened this issue Nov 26, 2024 · 0 comments

Comments

@rdsfj
Copy link

rdsfj commented Nov 26, 2024

Hello πŸ™‹β€β™€οΈ

I'm using single-spa-layout and it works great so far!
One thing I'm missing though is that the entrypoint single-spa-layout/server doesn't export any types, but just its JS API.
I've been using a patch and patch-package for some time now, so I thought I could contribute the changes.

I'd follow the pattern that's already there for the main entrypoint:

  • Create single-spa-layout-server-interface.ts with additional type exports
  • Export types used in the public API: HTMLTemplateOptions, ServerLayout, AppToRender, ApplicationRenderResult, RenderResult.
  • Point the types field in package.json to the new file.

Would you accept a PR for these changes?

Best regards
Simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant