Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test resulting mime against those in supported.js ? #711

Open
2 tasks done
sly7-7 opened this issue Dec 24, 2024 · 0 comments
Open
2 tasks done

Test resulting mime against those in supported.js ? #711

sly7-7 opened this issue Dec 24, 2024 · 0 comments
Labels
enhancement Add new functionality

Comments

@sly7-7
Copy link

sly7-7 commented Dec 24, 2024

Description

It seems to me it could improve the test harness by checking if the result of the functions is consistent with the one in supported.js.
for example here:

t.is(typeof mime, 'string');

using something like t.true(supportedMimeTypes.has(mime));

Existing Issue Check

  • I have searched the existing issues and could not find any related to my problem.

File-Type Scope Acknowledgment

  • I understand that file-type detects binary file types and not text or other formats.
@sly7-7 sly7-7 added the enhancement Add new functionality label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality
Projects
None yet
Development

No branches or pull requests

1 participant