Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.18.4 broke linting from forks #172

Closed
rsamborski opened this issue Sep 22, 2023 · 4 comments · Fixed by #173
Closed

v0.18.4 broke linting from forks #172

rsamborski opened this issue Sep 22, 2023 · 4 comments · Fixed by #173

Comments

@rsamborski
Copy link

Latest v0.18.4 release seems to have broken linting of code coming in from forks, examples:

As a workaround I had to lock to previous version (v0.18.3) which passes correctly - see here
@rsamborski rsamborski mentioned this issue Sep 22, 2023
Merged
@sindresorhus
Copy link
Owner

// @hyperupcall

@hyperupcall
Copy link
Contributor

I am able to reproduce - working on a fix

@hyperupcall
Copy link
Contributor

hyperupcall commented Sep 22, 2023 •
edited
Loading

This broke linting because the code did not take into account that HEAD may not point to a branch - it could be in a detached state. And this commonly occurs in Github Actions when @actions/checkout is used to clone a repository.

The linked issue fixes this by:

  1. Reading the config key clone.defaultRemoteName
  2. If that config key was not set, then it is defaulted to origin (the original default)

@hyperupcall hyperupcall mentioned this issue Sep 22, 2023
Merged
@rsamborski
Copy link
Author

@hyperupcall Thank you for a super fast fix. I have tested and confirmed that v0.18.5 works correctly with our repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sindresorhus @rsamborski @hyperupcall