Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception for title case and list item punctuation ending with .js #157

Open
Symbitic opened this issue Jan 31, 2023 · 7 comments
Open

Exception for title case and list item punctuation ending with .js #157

Symbitic opened this issue Jan 31, 2023 · 7 comments

Comments

@Symbitic
Copy link

I'm working on a list called awesome-babylonjs.

One problem I'm getting is that awesome-lint complains about the heading and list item description if the final word is "Babylon.js" because of the period. I believe an exception should be added so that a sentence ending in ".js" will not count as an error. 3D Tetris created with Babylon.js. just isn't natural.

@sindresorhus
Copy link
Owner

3D Tetris created with Babylon.js. just isn't natural.

I don't see any problem with that. It's just a normal sentence.

You would not write 3D Tetris created with Babylon.js This is a new sentence. for two sentences.

@Symbitic
Copy link
Author

Symbitic commented Feb 1, 2023

"3D Tetris created with Babylon.js."

See the description this comes from here: https://github.com/annamjo/3DTetrisBabylon
To pass the lint, I would need to add a period to the end of the description.

A period being the last character in a sentence when the final word ends in ".js" feels wrong.

@sindresorhus
Copy link
Owner

With your logic 3D Tetris created with Babylon.js. This is a new sentence. is wrong too.

@sindresorhus sindresorhus closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2023
@Symbitic
Copy link
Author

Symbitic commented Feb 2, 2023

@sindresorhus What about titles then? Awesome Babylon.js or Awesome Node.js?

@sindresorhus
Copy link
Owner

What about them? They are not sentences.

@Symbitic
Copy link
Author

Symbitic commented Feb 2, 2023

Not sentences, but they are titles. awesome-heading objects to them.

@sindresorhus
Copy link
Owner

That is a bug

@sindresorhus sindresorhus reopened this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants