Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists items should not create nested paragraphs #25

Open
madeleineostoja opened this issue May 30, 2017 · 5 comments
Open

Lists items should not create nested paragraphs #25

madeleineostoja opened this issue May 30, 2017 · 5 comments
Assignees
Labels

Comments

@madeleineostoja
Copy link

Lists currently generate the following markup

Content:

- List item

Output:

<ul>
  <li>
    <p>List item</p>
  </li>
</ul>

It should generate this markup:

<ul>
  <li>List item</li>
</ul>

This is breaking for any case where you have other content inside list items and are expecting inline content (as would be intuitively expected). Case in point: custom list bullets in ::before elements on Simpla's Privacy Policy. Using simpla-article results in a newline between the bullet and the list item content, since paragraphs are blocks by default.

@madeleineostoja
Copy link
Author

madeleineostoja commented May 30, 2017

Will monkey patch with CSS on simpla.io for now to continue dogfooding, but this is almost breaking IMO, because it also adds phantom margins to list items (p margins)

@madeleineostoja
Copy link
Author

madeleineostoja commented May 30, 2017

If this is non-trivial to patch, then we should at least add the following to the plugin CSS discussed in #23, which would restore regular behavior (p's act as spans)

li p {
  display: inline;
}

@madeleineostoja
Copy link
Author

@bedeoverend worth doing CSS hack for this now or fixing it properly?

@bedeoverend
Copy link
Contributor

@seaneking probably worth adding CSS hack. I think doing this will mean re-writing inputrules utility functions, which will probably take awhile

@madeleineostoja
Copy link
Author

Alright, do you want to add that to the sheet applied for #23 for now then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants