RFC: The module must not manage xinetd files and services when $package_ensure == 'absent'. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschonec
force-pushed
the
package_uninstall_should_not_manage_other_files
branch
2 times, most recently
from
6333aec to
e441b82
Compare
|
Moved into an issue for discussion at #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uninstalling the xinetd package, this module attempts to manage /etc/xined.conf, /etc/xinetd.d/ files and attempts (in vain) to start the xinetd service.
I couldn't figure out how to open a new issue so I've commented the init.pp file appropriately and am asking for comments on this issue.
I have about 50 servers that need xinetd with the exception of one. In the node's YAML file, I've put "xinetd::package_ensure: absent" and the module fails because it's trying to manage the xinetd files when it shouldn't.
Yes, I realize I could write a conditional check NOT to include ::xinetd::service but then I'd eventually have spaghetti code trying to work around the module's bug. I'm kind of a purist and believe that the module should do no harm even when it's called and the packages don't need to be installed.