From 4f54eb21599c9cc9618ef075d0cfaf9ea035d4c0 Mon Sep 17 00:00:00 2001
From: simonmcallister0210
 <56324559+simonmcallister0210@users.noreply.github.com>
Date: Sat, 21 Oct 2023 18:07:32 +0100
Subject: [PATCH] refactor: remove automatic npm releases from git workflow
 (#19)

* add DS_Store to gitignore

* remove automatic npm release, do them manually from now on

* rm node14 and add node20 for testing in github workflows

---------

Co-authored-by: Simon McAllister <simonmcallister@simons-mbp.home>
---
 .github/workflows/release.yml | 19 ++-----------------
 .github/workflows/test.yml    |  4 ++--
 .gitignore                    |  5 ++++-
 3 files changed, 8 insertions(+), 20 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 4a57250..cbf5748 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -11,13 +11,13 @@ jobs:
     strategy:
       matrix:
         # https://what-version-of-node.js.org/
-        node-version: [14.x, 16.x, 18.x] # remember to update this when support is added/dropped
+        node-version: [16.x, 18.x, 20.x] # remember to update this when support is added/dropped
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v3
         with:
-          node-version: 16 # remember to update this when support is added/dropped
+          node-version: 18 # remember to update this when support is added/dropped
       - run: npm ci
       - run: npm run lint
       - run: npm run test
@@ -53,18 +53,3 @@ jobs:
     outputs:
       releases_created: ${{steps.release.outputs.releases_created}}
 
-  npm-publish:
-    runs-on: ubuntu-latest
-    needs: [github-release]
-    if: ${{ needs.github-release.outputs.releases_created == 'true' }} # only publish to npm if a github release has been made
-    steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
-        with:
-          node-version: 16 # remember to update this when support is added/dropped
-          registry-url: "https://registry.npmjs.org"
-      - run: npm ci --production
-      - run: npm run build
-      - run: npm publish # SUPPORTING OLDER MAJOR VERSIONS: add a tag so that 'latest' tag isn't used, e.g. `npm publish --tag v1-latest`
-        env:
-          NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 713b9f6..eda5be1 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -11,13 +11,13 @@ jobs:
     strategy:
       matrix:
         # https://what-version-of-node.js.org/
-        node-version: [14.x, 16.x, 18.x] # remember to update this when support is added/dropped
+        node-version: [16.x, 18.x, 20.x] # remember to update this when support is added/dropped
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v3
         with:
-          node-version: 16 # remember to update this when support is added/dropped
+          node-version: 18 # remember to update this when support is added/dropped
       - run: npm ci
       - run: npm run lint
       - run: npm run test
diff --git a/.gitignore b/.gitignore
index 5b01f2d..14e5b9c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -130,4 +130,7 @@ dist
 .yarn/unplugged
 .yarn/build-state.yml
 .yarn/install-state.gz
-.pnp.*
\ No newline at end of file
+.pnp.*
+
+# macOS
+.DS_Store