-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix:Puppeteer reports a weird warning (#247) #248
base: master
Are you sure you want to change the base?
Fix:Puppeteer reports a weird warning (#247) #248
Conversation
Fixed the weird warning, and bumped up the puppeteer version.
@@ -53,7 +53,7 @@ | |||
"iconv-lite": "^0.6.3", | |||
"listr": "^0.14.3", | |||
"marked": "^4.2.12", | |||
"puppeteer": ">=8.0.0", | |||
"puppeteer": "^21.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency has such a wide range on purpose for deduplication reasons when using md-to-pdf in projects that already use puppeteer.
I don't think this needs to be fixed... it's just a deprecation warning, the change in Puppeteer will have no actual impact on the output of |
Agreed, but it give a big yellow warning , which may not be very comfortable for the users to see when they try out the tool. So thought to handle. |
@simonhaenisch Can we merge this PR? As It panics new users with that weird msg. |
The The |
Fixed the weird warning, and bumped up the puppeteer version.