Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:Puppeteer reports a weird warning (#247) #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thunderhunt
Copy link

Fixed the weird warning, and bumped up the puppeteer version.

Fixed the weird warning, and bumped up the puppeteer version.
@@ -53,7 +53,7 @@
"iconv-lite": "^0.6.3",
"listr": "^0.14.3",
"marked": "^4.2.12",
"puppeteer": ">=8.0.0",
"puppeteer": "^21.1.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency has such a wide range on purpose for deduplication reasons when using md-to-pdf in projects that already use puppeteer.

@simonhaenisch
Copy link
Owner

I don't think this needs to be fixed... it's just a deprecation warning, the change in Puppeteer will have no actual impact on the output of md-to-pdf afaik.

@thunderhunt
Copy link
Author

I don't think this needs to be fixed... it's just a deprecation warning, the change in Puppeteer will have no actual impact on the output of md-to-pdf afaik.

Agreed, but it give a big yellow warning , which may not be very comfortable for the users to see when they try out the tool. So thought to handle.

@thunderhunt
Copy link
Author

@simonhaenisch Can we merge this PR? As It panics new users with that weird msg.

@simonhaenisch
Copy link
Owner

simonhaenisch commented Sep 8, 2023

The headless: 'new' config change yeah we can merge but can you please verify that the --devtools flag still works (i.e. when you run md-to-pdf --devtools, it opens the browser, i.e. headful mode, with the rendered page, and opens dev tools).

The package.json and package-lock.json changes I don't want, please revert them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants