Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Pass Stereo for VR #2

Open
ddutchie opened this issue Oct 23, 2018 · 8 comments
Open

Single Pass Stereo for VR #2

ddutchie opened this issue Oct 23, 2018 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ddutchie
Copy link

Thanks for a great asset.

I have started making it compatible with SPS for VR compatability.

It works mostly by adding

UnityStereoTransformScreenSpaceTex(.i.uv);

To some parts in stochasticSSR.shader but the view normal and reflection direction is still wrong.
Any ideas?

@simeonradivoev
Copy link
Owner

I will have to look into it. Probably just need to multiply them with the appropriate matrix.

@ninlilizi
Copy link

I know exactly the problem, as encountered this while working on SEGI.
This is basically covers how to fix the projection matrix for stereo

https://gamedev.stackexchange.com/questions/131978/shader-reconstructing-position-from-depth-in-vr-through-projection-matrix/144753#144753

@simeonradivoev
Copy link
Owner

I need to see also how to integrate 'UnityStereoTransformScreenSpaceTex ' into the compute shader. The post-processing stack does it but not sure how. I got multi-pass stereo rendering implemented, but am having trouble with the single pass one.

@simeonradivoev
Copy link
Owner

I got the temporal filtering working for multi-pass rendering but still no luck for single-pass rendering. I don't think single-pass rendering even supports deferred rendering.

@ninlilizi
Copy link

It does, if not a little finiky. Nigiri works in single pass deferred.

@ninlilizi
Copy link

I should stop derping around and fix this asset. I could prob do it justice now with what I've learnt since.

@simeonradivoev
Copy link
Owner

simeonradivoev commented Feb 5, 2020

I couldn't get Deferred to work in VR with single-pass stereo and the default unity rendering. Even without post-processing on the latest version. URP doesn't have deferred yet, so that leaves HDRP.

@ninlilizi
Copy link

I've not done anything with the SRP's yet. So little clue what works with them.

I should have some time soon to have another look at this.

@simeonradivoev simeonradivoev added enhancement New feature or request help wanted Extra attention is needed labels Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants