Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default config for loggingBlacklist #215

Open
chillu opened this issue Mar 2, 2020 · 0 comments
Open

Default config for loggingBlacklist #215

chillu opened this issue Mar 2, 2020 · 0 comments

Comments

@chillu
Copy link
Member

chillu commented Mar 2, 2020

Devs who read all of your instructions will come across the bit where you can opt-in to filtering out sensitive parameters from log messages. I understand the rationale behind this: Omnipay is an abstraction layer, parameter names can vary between implementations.

But: I think filtering out values for keys like token or password is a pretty universal need, and should be covered in the default configuration regardless of implementation. This way you don't run the risk of logging very sensitive data to external systems (logging services) by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant