-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No font options available for Braille (-Brai) #19
Comments
Perhaps the "safe fonts" could be a fallback when no fonts are offered. |
I think we should give this feedback to wsTech. When I query lff with en-Brai (https://lff.api.languagetechnology.org/lang/en-brai) I get this response: {"defaultfamily":[""],"apiversion":0.3,"families":{"":{"family":"","familyid":""}}} so I think the language picker is returning the correct results and if it should return a different response, this should be indicated by the lff. |
I'm giving feedback there when I find good options:
I was wondering if you'd want a fallback when the api gives no options. And if not, that's perfectly find---you can close this issue. |
If there are no recommended fonts, should we hid the font choice control? Should we not call setFont call back if there is no font? |
Hmm, good questions. I'm guessing a disabled dropdown with some "No recommended fonts" text would be less confusing than having the whole control disappear. I don't immediately see any harm in letting |
I like the idea of calling setFont anyway (at least) since if the user picked a language with a font and are now editing their choice, you don't want the old font to be retained. Disabled controls are tricky since there is no easy way to make the "No recommended fonts" message appear... (Titles and hovering is also disabled when the control is disabled.) |
I could put a little information (i) after the control if it is disabled with the text on that. Does that sound like a good idea? |
You could have the |
ok, I made this change and merged to master branch. |
5a41dd5 looks good |
Many major languages have a -Brai script option for Braille; selecting this results in an empty font list.
The text was updated successfully, but these errors were encountered: