copy in poc work #1
Conversation
… all projects at once
…er of places it's used
…make internal visible to the tests project
…g changes. Also pass in ChangeContext into NewEntry and allow it to be async
…, write tests for helpers and some queries that can't be extracted.
There was a problem hiding this comment.
I think I've provided all the suggestions I have to offer at this point.
I still feel like this improvement (or preferably something better 😉) is worth doing.
All in all, this is very respectable, solid, clean, well-tested code.
Kudos x10! 🎉
Load testing is perhaps the one thing that could derail this Crdt magic.
refactor how commits get saved so the commit hash can be updated when processing snapshots. Change null parent hash to be `0000`
…changes to the same entity in a single commit. Also wrote some tests to ensure basic snapshot features are preserved.
…ctor some related code to simplify query when ignoreChangesAfter is null
… to maintain this restriction.
…, fix spelling mistake in another comment
…was left public as it's just a thin layer over sqlite
add comment about commit metadata `AddChange` to specify commit metadata.
|
@jasonleenaylor when you get a chance, I made the changes we talked about. CrdtRepository is now internal, and the DataModel tests now use a Mock time provider to specify the time used for commits. Other tests which are either testing sync issues with multiple commits being added at once, or tests at a lower level are just hard coding the date time on their own. I've also created a |
No description provided.