Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAB: Styles #691

Open
chrisvire opened this issue Sep 17, 2024 · 0 comments
Open

DAB: Styles #691

chrisvire opened this issue Sep 17, 2024 · 0 comments

Comments

@chrisvire
Copy link
Member

The styles for a DAB app are generated (with DAB built on 9/16 or later) in data/styles/dab-app.css.

With the Scripture app, there were styles that were based on body and these didn't work since we don't have control over the body element. In convert/convertStyle.ts, we changed the styles that started with body to instead begin with #container. So the root element of the lexicon view will need <div id="container"> so that the styles that were based off of body will work.

There may be other changes that are needed to the styles. Hopefully, we can use the same convert/convertStyles.ts for both SAB and DAB. Make sure not to break it for SAB.

@chrisvire chrisvire converted this from a draft issue Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant