Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entra ID OICDIssuer cannot return boolean claims in IDToken #1698

Closed
ProbstenHias opened this issue Apr 11, 2024 · 2 comments
Closed

Entra ID OICDIssuer cannot return boolean claims in IDToken #1698

ProbstenHias opened this issue Apr 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ProbstenHias
Copy link

ProbstenHias commented Apr 11, 2024

Hi guys👋,

We are currently in the process of setting up my own sigstore with scaffold.
As our oidc issuer we want to use a custom application in Azure Entra ID.

In entra id you have to set up custom claims to return fields like email and email_validated. Unfortunately these claims cannot have a boolean value, but are either numbers or string.

For that reason when we try to sign with cosign the GetIDToken method in the oauthflow/flow.go method returns the error:

(main.go:74: error during command execution: signing [...]: getting signer: getting key from Fulcio: retrieving cert: json: cannot unmarshal string into Go struct field claims.email_verified of type bool)

I would do the implementation of allowing both string and boolean values for email_validated if there are no concerns why this should not be done.

I would propose using a custom Unmarshal that allows both bool and str, or making the Verified field an interface.

Thanks 😄

@ProbstenHias ProbstenHias added the enhancement New feature or request label Apr 11, 2024
@bobcallaway
Copy link
Member

https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims shows email_verified as a boolean.... so should a bug be opened to make Entra compliant with the spec?

@haydentherapper
Copy link
Contributor

sigstore/fulcio#1744 should fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants