Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuf kms key type is incorrect #948

Closed
jku opened this issue Jan 19, 2024 · 2 comments · Fixed by #949
Closed

tuf kms key type is incorrect #948

jku opened this issue Jan 19, 2024 · 2 comments · Fixed by #949
Labels
bug Something isn't working

Comments

@jku
Copy link
Member

jku commented Jan 19, 2024

tuf/kms.tf now defines an online key for root-signing (not used yet for either prod or staging but will be). This key is EC_SIGN_P384_SHA384 which does not match the current production keytype and is in fact incompatible with cosign.

We should use EC_SIGN_P256_SHA256: this is recommended by GCP and should match the production keytype

@jku jku added the bug Something isn't working label Jan 19, 2024
@jku
Copy link
Member Author

jku commented Jan 19, 2024

@haydentherapper I can handle this on monday if you don't do it by then.

I'm not totally sure what the right method is though.

  • changing only the algorithm likely just changes the "algorithm for next version of this key"
  • I think there's no way to manually trigger a new key version in terraform?
  • Does terraform create a completely new key if I change tuf_key_name value and the algorithm?

@haydentherapper
Copy link
Contributor

#949 for the fix. I think you can create a new key version resource to force a new version to be created in terraform.

The other option is to create a new key with a new name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants