-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for converting manifests to in-toto statements #248
Comments
Included in my draft work, will send a draft PR |
THIS IS DRAFT, WIP. Will split into separate PRs once it works. But posting publicly to show what the plans are (sigstore#224, sigstore#248, sigstore#240, sigstore#111). Signed-off-by: Mihai Maruseac <[email protected]>
I've had some thoughts about the intoto format. In #111, we expressed concern over listing each file as intoto subjects, because tooling like cosign can be used to (wrongly) verify only a subset of subjects. Here's an idea that may be able to address this concern:
So overall it would look like the following: {
"_type": "https://in-toto.io/Statement/v0.1",
"predicateType": "https://something/model-signing/v1",
"subject": [
{
"digest":
{
"sha256": "blabla"
}
},
],
"predicate": {
"serialization": "some-name/v1",
"files": {
{
"path": "to/file1",
"digest":
{
"sha256": "bla",
}
},
{
"path": "to/file2",
"digest":
{
"custom": "bla",
}
},
},
}
} |
I agree with you. It only feels like "abusing" the format which is mostly because sigstore has hard coded the acceptable hashes in their code base. Perhaps it would be the best to go down the route of our own format to avoid additional headache. |
THIS IS DRAFT, WIP. Will split into separate PRs once it works. But posting publicly to show what the plans are (sigstore#224, sigstore#248, sigstore#240, sigstore#111). Signed-off-by: Mihai Maruseac <[email protected]>
THIS IS DRAFT, WIP. Will split into separate PRs once it works. But posting publicly to show what the plans are (sigstore#224, sigstore#248, sigstore#240, sigstore#111). Signed-off-by: Mihai Maruseac <[email protected]>
THIS IS DRAFT, WIP. Will split into separate PRs once it works. But posting publicly to show what the plans are (sigstore#224, sigstore#248, sigstore#240, sigstore#111). Signed-off-by: Mihai Maruseac <[email protected]>
Description
Tracking bug for manifest to in-toto statement conversion.
In order to sign and store model signatures in a sigstore bundle the manifest must be converted to an in-toto statement.
The text was updated successfully, but these errors were encountered: