Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulcio API incorrectly specifies support for RSA-PSS #1858

Open
haydentherapper opened this issue Nov 6, 2024 · 2 comments
Open

Fulcio API incorrectly specifies support for RSA-PSS #1858

haydentherapper opened this issue Nov 6, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@haydentherapper
Copy link
Contributor

Fulcio's API specifies that RSA-PSS is a supported algorithm. However, the algorithm field in the API is not used when parsing the public key. The key content is read without the algorithm, parsed, then used to verify a proof of possession signature. Without specifying PSS options for verification, verification fails. Certificate signing will also fail to detect the correct key type without explicitly specifying the signature algorithm on signing.

In the underlying sigstore/sigstore library, there is support for configuring signers and verifiers with RSA-PSS. I propose we:

a) Add a field for RSA-PKCS1v1.5, and use that as the default RSA scheme to align with all Sigstore client implementations
b) When RSA-PSS is set, enable RSA-PSS for signature verification and explicitly set the SignatureAlgorithm. RSA-PSS is not widely supported by Sigstore clients, so I would expect only API users to set this for now.

@haydentherapper haydentherapper added the bug Something isn't working label Nov 6, 2024
@loosebazooka
Copy link
Member

@haydentherapper
Copy link
Contributor Author

To avoid breaking any clients, then we'll need to continue to assume that RSA-PSS is actually PKCS1v1.5. We can add new fields for RSA-PSS and PKCS1v1.5 and deprecate the current "RSA-PSS" field. I'd suggest we use a subset of enums from https://github.com/sigstore/protobuf-specs/blob/main/protos/sigstore_common.proto#L62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants