Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add support for custom attestation predicate types #472

Closed
dlorenc opened this issue Jul 23, 2021 · 2 comments · Fixed by #504
Closed

Feature: Add support for custom attestation predicate types #472

dlorenc opened this issue Jul 23, 2021 · 2 comments · Fixed by #504

Comments

@dlorenc
Copy link
Member

dlorenc commented Jul 23, 2021

Right now we hardcode a specific one for cosign. We should add a flag to select a different one, and then have an index of "well-known" predicates that can be unmarshalled correctly/validated into a go struct
developer-guy added a commit to developer-guy/cosign that referenced this issue Jul 28, 2021
@developer-guy
add well-known attestation specs support to the attest command
068d500 
Fixes sigstore#472

Signed-off-by: Batuhan Apaydın <[email protected]>
@developer-guy developer-guy mentioned this issue Jul 28, 2021
Merged
@developer-guy
Copy link
Member

The documentation for the "well-known" precidates within the in-toto's attestation spec can be found by following the link:

https://github.com/in-toto/attestation/blob/main/spec/README.md

dlorenc pushed a commit that referenced this issue Jul 29, 2021
@developer-guy
add well-known attestation specs support to the attest command (#504)
7e9cdfb 
* add well-known attestation specs support to the attest command

Fixes #472

Signed-off-by: Batuhan Apaydın <[email protected]>

* fix lint issues, fix required json tag logic

Signed-off-by: Batuhan Apaydın <[email protected]>

* fix e2e test and license problems

Signed-off-by: Batuhan Apaydın <[email protected]>
@developer-guy
Copy link
Member

there is also another discussion going on about another type of predicate for vulnerability scans.
#442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add well-known attestation specs support to the attest command developer-guy/cosign
2 participants
@dlorenc @developer-guy