Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

Output mode-specific parameters in __main__.model_stats #54

Open
slebastard opened this issue Apr 14, 2021 · 1 comment
Open

Output mode-specific parameters in __main__.model_stats #54

slebastard opened this issue Apr 14, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@slebastard
Copy link
Contributor

For tracking purposes as well as to produce explainability analyses, it would be useful for each model run with python3 -m predictsignauxfaibles to output model-specific parameters into model_stats.

A use case would for the logistic regression would be to output its coefficient and baseline variables in order to find the contribution of each variables to the score a posteriori. Note that this could exist independently from the explanations pushed to the collection Scores:

  • in the collection Scores, we could output the contribution of a group of variables for each SIRET input
  • in model_stats, we would store model-specific parameters

A solution could be to specify in model_config.py the name of model attributes to be saved into model_stats.json, and to have a function towards the end of __main__.run(args) that collects those parameters into model_stats
WDYT?

@vviers vviers added the enhancement New feature or request label Apr 15, 2021
@vviers
Copy link
Contributor

vviers commented Apr 15, 2021

For tracking purposes as well as to produce explainability analyses, it would be useful for each model run with python3 -m predictsignauxfaibles to output model-specific parameters into model_stats.

A use case would for the logistic regression would be to output its coefficient and baseline variables in order to find the contribution of each variables to the score a posteriori. Note that this could exist independently from the explanations pushed to the collection Scores:

  • in the collection Scores, we could output the contribution of a group of variables for each SIRET input
  • in model_stats, we would store model-specific parameters

I agree that this would be a nice to have

A solution could be to specify in model_config.py the name of model attributes to be saved into model_stats.json, and to have a function towards the end of __main__.run(args) that collects those parameters into model_stats

I can see how this implementation could add a lot of complexity to __main__ (which is already pretty big and hard to read)...
I think we should refactorize __main__ before we tackle this. For example by creating a SFModelRun class and implementing util functions or methods around it.

Let's talk about it soon 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants