Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

Use scikit-learn for GAMs #16

Open
vviers opened this issue Jan 27, 2021 · 2 comments
Open

Use scikit-learn for GAMs #16

vviers opened this issue Jan 27, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@vviers
Copy link
Contributor

vviers commented Jan 27, 2021

A huge step towards implementing GAMs in scikit-learn was taken 3 days ago when this PR was merged.

This will likely allow us to get rid of pyGAM (which is OK but not mature and stable enough imo, see for example #12) and to rely fully on the great scikit-learn ecosystem instead.

Anyone interested in giving it a go ?

@vviers vviers added enhancement New feature or request help wanted Extra attention is needed labels Jan 27, 2021
@lcrmorin
Copy link

lcrmorin commented Feb 26, 2021

May I suggest trying glmnet ? (from the author of elements of statistical learning). It works in a sklearn frameworks. Basically offer logistic regression + an iterative framework for regularisation (-> variable selection) and hyperparameter tuning. The hyperparameter tuning is done on an information criteria so that it doesn't need an aditionnal framework for tunning. The loss of spline (ie mostly smoothing) can largely be compensated trough expert based feature selection + feature transformation.

Do you think it could be tried easily ? It could work ?

@vviers
Copy link
Contributor Author

vviers commented Mar 1, 2021

That's a great point ! If we end up using something different than GAMs then this package would be worth looking into :)

However, looking at the github repo for the package, it seems much less maintained and used than scikit-learn and so we would need a really good reason (like a feature that's critical to our work) to use it instead of scikit.

Do you have a specific example of something that glmnet does and that we cannot get in scikit-learn ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants