Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some unit test validations #232

Merged
merged 2 commits into from
Nov 13, 2024
Merged

add some unit test validations #232

merged 2 commits into from
Nov 13, 2024

Conversation

fiercegecko
Copy link
Contributor

@fiercegecko fiercegecko commented Sep 14, 2024 •
edited
Loading

After getting burnt on a few apply-time errors in a gitops environment, I was hoping to add a few validation checks.

#233

@fiercegecko fiercegecko mentioned this pull request Sep 14, 2024
Open
@daniel-corbett
Copy link
Collaborator

Hi @fiercegecko - thanks for submitting this! Can you please run make docs ?

@fiercegecko
Copy link
Contributor Author

Sure thing @daniel-corbett, should be all set now.

@daniel-corbett daniel-corbett merged commit 0b85b22 into signalsciences:main Nov 13, 2024
2 checks passed
@daniel-corbett
Copy link
Collaborator

Thanks again for your contribution @fiercegecko ! Greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-corbett daniel-corbett daniel-corbett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiercegecko @daniel-corbett