You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Google seems to have added history type suggestions to the search suggestions (example below from the app) at some point. These are under a different key to regular search suggestions so the current implementation will fail if history exists (example below of the JSON structure).
Proposal:
get_search_suggestions revised to:
look at historySuggestionRenderer if searchSuggestionRenderers not in the list of contents.
return suggestion type as well as the suggestions themselves.
To Reproduce
Steps to reproduce the behavior:
Setup a new Oauth session
Run get_search_suggestions twice in a row (first time adds it to your history).
KeyError: 'searchSuggestionRenderer'
Additional notes
From the screenshot, seems there is also a way to delete search history suggestions, this could be a future enhancement
The text was updated successfully, but these errors were encountered:
Describe the bug
Google seems to have added history type suggestions to the search suggestions (example below from the app) at some point. These are under a different key to regular search suggestions so the current implementation will fail if history exists (example below of the JSON structure).
Proposal:
get_search_suggestions revised to:
To Reproduce
Steps to reproduce the behavior:
Additional notes
From the screenshot, seems there is also a way to delete search history suggestions, this could be a future enhancement
The text was updated successfully, but these errors were encountered: