Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate dbus-native #263

Open
acrisci opened this issue Apr 19, 2019 · 5 comments
Open

Deprecate dbus-native #263

acrisci opened this issue Apr 19, 2019 · 5 comments

Comments

@acrisci
Copy link

acrisci commented Apr 19, 2019

Thanks for your work creating dbus-native.

I have created a fork of the project called dbus-next with many bugfixes and enhancements that I believe fixes many of the issues on your issue tracker as well as the following:

  • fully featured high-level and low-level interfaces
  • a more intuitive type system
  • comprehensive documentation for the public api
  • integration tests for all library features
  • used in six electron media players through the mpris-service library.

I was wondering if you would deprecate this library and send your users my way. I am also open to merging the projects.

Thanks.

@sidorares
Copy link
Owner

sidorares commented Apr 19, 2019

hey @acrisci , thanks for your efforts ( I saw your email but didn't have time to respond, I'm sorry )

Happy to see deprecate my version in favour of yours, or merge and move to https://github.com/dbusjs , whatewher you think is better

@sidorares
Copy link
Owner

At current stage, is your code backwards compatible? Do you want to re-use npm name? If yes, whe can 1) mifrate "official" repo to dbusjs org 2) I'll add you publish rights to npm and you publish latest version of your code

@acrisci
Copy link
Author

acrisci commented Apr 19, 2019

At current stage, is your code backwards compatible?

Unfortunately no. I rewrote everything except the marshallers.

Do you want to re-use npm name?

I think this would be good because dbus-native has very high visibility.

If yes, whe can 1) mifrate "official" repo to dbusjs org 2) I'll add you publish rights to npm and you publish latest version of your code

This sounds good to me.

@sidorares
Copy link
Owner

Unfortunately no. I rewrote everything except the marshallers.

I guess with enough of communication and major version change this is still possible

@acrisci
Copy link
Author

acrisci commented Jun 2, 2019

With the latest 0.7.1 release of dbus-next, I think I'm ready to make the api stable so I'm ready to take action on this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants