Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extfs repair and resize #10116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: extfs repair and resize #10116

wants to merge 1 commit into from

Conversation

smira
Copy link
Member

@smira smira commented Jan 10, 2025

Fixes #10103

@smira smira added this to the v1.9 milestone Jan 10, 2025
frezbo
frezbo approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@frezbo frezbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting this test worked, or it's wrong https://github.com/siderolabs/talos/blob/main/pkg/makefs/ext4_test.go#L64

@smira
Copy link
Member Author

smira commented Jan 10, 2025

interesting this test worked, or it's wrong main/pkg/makefs/ext4_test.go#L64

I think it's fine, but the filesystem is/was clean, we have to make it specifically dirty (like unclean reboot I guess)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsseng dsseng dsseng approved these changes

@frezbo frezbo frezbo approved these changes

Assignees
No one assigned
Labels
integration/image-cache status/ok-to-test
Projects
Backports to v1.9
Status: Proposed
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

resize2fs needs e2fsck
4 participants
@smira @frezbo @dsseng @talos-bot