resize2fs needs e2fsck

[srgvg]

Bug Report

Description

AFAIK, resizing an online ext4 partition typically always needs a preliminary file system check (e2fsck).
The latter however is not implemented in pkg/makefs/ext4. AFAICS, Ext4Resize was only implemented in context of handling the new image cache in v1.9, which is how I found this out.

Logs

talosctl get volumestatus -{n,e}172.31.32.201 IMAGECACHE -o yaml

(...)

    errorMessage: |+
        error growing filesystem: error growing ext4: exit status 1: resize2fs 1.47.1 (20-May-2024)
        Please run 'e2fsck -f /dev/nvme0n1p6' first.

Environment

• Talos version: 1.9.1
• Kubernetes version: N/A
• Platform: AMD64 baremetal, nvme disk

Relevant Config

I got this working for now by avoiding the need for a resize by setting the same exact sizes with following configurations:

apiVersion: v1alpha1
kind: VolumeConfig
name: IMAGECACHE
provisioning:
  diskSelector:
    match: 'system_disk'
  minSize: 8GiB
  maxSize: 8GiB
  grow: False

and for generating the installer artifacts:

docker run --rm -t \
	-v ${buildir}:/secureboot:ro \
	-v ${buildir}:/out \
	-v ${buildir}/image-cache.oci:/image-cache.oci:ro \
	-v /dev:/dev \
	--privileged \
	ghcr.io/siderolabs/imager:${TALOS_VERSION} \
	iso \
	--image-disk-size 8GiB \
	--image-cache /image-cache.oci \
	--base-installer-image ${installimage} \
	${sysext}

(Keep in mind, setting min/maxSize to 8GB will also trigger a resize if --image-disk-size is set to 8GiB (giga vs gigi)

Proposed Solution

Always perform an e2fsck before resize2fs.