How do i rebind multiple pci devices using the new machine config document PCIDriverRebindConfig ?

[Darkfella91]

Hello, i've been testing the new machine config document for rebinding pci devices to vfio driver, but i was wondering is it possible to rebind multiple devices ? I tried adding separate documents for each id but it wouldnt allow to have duplicates , i also tried naming them but that isnt allowed aswell.

[frezbo]

Could you provide an example use? Multiple named documents should be supported

[Darkfella91]

When i try to name the document i receive a validation error

# Editing MachineConfigs.config.talos.dev/v1alpha1 at node 192.168.91.9
#
# 1 error occurred:
#       * 192.168.91.9: rpc error: code = InvalidArgument desc = unknown keys found during decoding:
# name: bind1
#
#
#
---
apiVersion: v1alpha1
kind: PCIDriverRebindConfig
name: bind1
pciID: 0000:0a:00.0
targetDriver: vfio-pci
---

[smira]

I'm not sure where does the name come from? Is it somewhere in the docs?

It should be pciID: https://www.talos.dev/v1.10/reference/configuration/hardware/pcidriverrebindconfig/

[Darkfella91]

Im trying to rebind 2 different pci devices to vfio driver and so i tried creating 2 separate documents and naming them, since unnamed documents can only be supplied once in the machine config. I was using this documentation as a reference https://www.talos.dev/v1.9/reference/configuration/

[frezbo]

Well i basically edited my machineconfig and added the driverrebind document to it like this .

apiVersion: v1alpha1
kind: PCIDriverRebindConfig
pciID: 0000:0a:00.0
targetDriver: vfio-pci
---
version: v1alpha1
debug: false
persist: true
machine
  <rest of the machineconfig>

This should work, you can add a second document like this

[Darkfella91]

I tried that but im receiving an error that duplicate document is not allowed.

#
# 1 error occurred:
#       * 192.168.91.9: rpc error: code = InvalidArgument desc = duplicate document v1alpha1/PCIDriverRebindConfig/ is not allowed

[frezbo]

thanks, I found the bug, will fix it for 1.9.1

[frezbo]

thanks, I found the bug, will fix it for 1.9.1

sorry, 1.10.0-alpha.1, since this is 1.10 feature only

[Darkfella91]

Yea, i figured. Thanks for developing this feature and wishing you guys happy holidays .