Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing source does not invalidate cache #64

Open
AlekSi opened this issue Jul 12, 2021 · 3 comments
Open

Changing source does not invalidate cache #64

AlekSi opened this issue Jul 12, 2021 · 3 comments

Comments

@AlekSi
Copy link
Contributor

AlekSi commented Jul 12, 2021

   - sources:
-      - url: https://ftp.gnu.org/gnu/make/make-4.3.tar.gz
+      - url: https://ftp.gnu.org/gnu/make/make-4.4.tar.gz
         destination: make.tar.gz
         sha256: e05fdde47c5f7ca45cb697e973894ff4f5d79e13b750ed57d7b66d8defc78e19
         sha512: 9a1185cc468368f4ec06478b1cfa343bf90b5cd7c92c0536567db0315b0ee909af53ecce3d44cfd93dd137dbca1ed13af5713e8663590c4fdd21ea635d78496b

If make-4.3.tar.gz was previously downloaded, that patch does not trigger a rebuild.

@smira
Copy link
Member

smira commented Jul 13, 2021

That works as expected, as long as sha256 stays the same (it's the way buildkit caching works)

@AlekSi
Copy link
Contributor Author

AlekSi commented Jul 13, 2021

Yes, I understand now how that works in BuildKit, but that's not "right" and is confusing for users. I wonder if we can do something about that.

@smira
Copy link
Member

smira commented Jul 13, 2021

Ah, I see what you mean, you "forgot" to update SHA. We could fix it by putting download URL in the download sub-tree, so that it changes from buildkit point of view.

AlekSi added a commit to AlekSi/talos-bldr that referenced this issue Jul 14, 2021
`bldr validate --checksums`.

Refs siderolabs#64.

Signed-off-by: Alexey Palazhchenko <[email protected]>
talos-bot pushed a commit that referenced this issue Jul 14, 2021
`bldr validate --checksums`.

Refs #64.

Signed-off-by: Alexey Palazhchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants