-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for binding in url attribute #7
Comments
Hi, I had the same requirement but the module didn't support the feature. So I had to make a tweak in angular-feed.js that I included in my project. In line 39, $attrs.url had to be replaced with $attrs.$observe('url', function(value){})... With this modification on line 39, my code looks like.
I wonder if the owner of this library can update this. |
@nzalheart - Can you please create a PR? I can push this change to master. |
very thank you for this edit :) I love you man ... |
I am trying to bind a variable as part of the url parameter passed to the
feed
directive, but it refuses to bind.For example, calling this doesnt work:
but static urls do. Any thoughts on how to implement this functionality? Using
ng-attr-url
doesn't work either, so beyond that I'm out of ideas.Love the drop-in functionality of the directive btw.
The text was updated successfully, but these errors were encountered: