#167 into [email protected] 🐘 call server response interceptors for database requests, add database api interceptors, add baseUrl field for database #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etabase api interceptors, add baseUrl field for database
MiaInturi
requested changes
Jun 1, 2024
Comment on lines
+118
to
+119
| describe('createDatabaseRoutes: interceptors', () => { | ||
| test('Should call response interceptors in order: api -> server', async () => { |
There was a problem hiding this comment.
- Я думаю можно в рамках этого же PR исправить: тесты на interceptors для
createRestRoutesиcreateGraphqQLRoutesне содержат проверку на вызов api response interceptor в цепочке interceptor-ов. Надо бы добавить - Я бы текущие тесты перенес в
createShallowDatabase.test.tsиcreateNestedDatabase.test.tsпо след. причинам:
2.1 текущий тест проверяет по сути только shallow interceptors, т.к. запрос на /users не делается
2.2 проверяется только get method
There was a problem hiding this comment.
По 1 пункту сделал тут: #177
...tabase/createDatabaseRoutes/helpers/createNestedDatabaseRoutes/createNestedDatabaseRoutes.ts
Show resolved
Hide resolved
...base/createDatabaseRoutes/helpers/createShallowDatabaseRoutes/createShallowDatabaseRoutes.ts
Show resolved
Hide resolved
|
И еще вопрос на обсудить - не хотим ли мы route request interceptor добавить? Потому что сейчас нет interceptor-а именно для запросов, которые совпали полностью по роутам |
MiaInturi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.