Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon changes #24

Merged
merged 5 commits into from
Feb 25, 2021
Merged

Icon changes #24

merged 5 commits into from
Feb 25, 2021

Conversation

acolytec3
Copy link
Collaborator

Update icons from substrate kitties to libp2p icons

@vercel
Copy link

vercel bot commented Aug 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shresthagrawal/jslibp2p-chat-tutorial/DGeS3mYXd2NYUdKZfHcX6djQUfHa
✅ Preview: https://jslibp2p-chat-tutorial-git-icon-changes-shresthagrawal.vercel.app

@vasa-develop
Copy link
Collaborator

Somehow I can't see the new logo in the versel preview.

@acolytec3
Copy link
Collaborator Author

acolytec3 commented Aug 8, 2020 via email

index.html Outdated
Comment on lines 57 to 72
<!-- <script src="//unpkg.com/docsify/lib/docsify.min.js"></script> -->
<script src="./resource/js/docsify.min.js"></script>
<!-- <script src="//unpkg.com/[email protected]/dist/docsify-pagination.min.js"></script> -->
<script src="./resource/js/docsify-pagination.min.js"></script>
<!-- <script src="//unpkg.com/docsify-copy-code@2"></script> -->
<script src="./resource/js/docsify-code-code.js"></script>
<!-- <script src="https://cdn.jsdelivr.net/npm/docsify-tabs@1"></script> -->
<script src="./resource/js/docsify-tabs.js"></script>
<!-- <script src="//unpkg.com/docsify/lib/plugins/search.min.js"></script> -->
<script src="./resource/js/search.min.js"></script>
<script src="//unpkg.com/prismjs/components/prism-rust.min.js"></script>
<!-- <script src="//unpkg.com/prismjs/components/prism-bash.min.js"></script> -->
<script src="./resource/js/prism-bash.min.js"></script>
<!-- Custom JS for CodeView -->
<!-- <script defer type="text/javascript" src="//unpkg.com/[email protected]/min/vs/loader.js"></script> -->
<script defer type="text/javascript" src="./resource/js/loader.js"></script>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luke-rucker I don't remember why I did this. It could be just for some testing and then forgot to fix it. I think we should correct this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.html Outdated
Comment on lines 18 to 21
<script defer type="text/javascript" src="./resource/js/config.js"></script>
<!-- <script defer type="text/javascript" src="https://substrate.dev/js/klaro.min.js"></script> -->
<script defer type="text/javascript" src="./resource/js/klaro.min.js"></script>
<!-- Global site tag (gtag.js) - Google Analytics with Klaro script -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these scripts were modified from the original one, but you can check it again to confirm

@shresthagrawal
Copy link
Owner

LGTM

@luke-rucker luke-rucker merged commit d5a6dc4 into master Feb 25, 2021
@luke-rucker luke-rucker deleted the icon-changes branch February 25, 2021 14:48
@luke-rucker luke-rucker linked an issue Feb 25, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the logo and visuals for the tutorial
4 participants