Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler show text report not working #390

Closed
IanTrudel opened this issue Nov 23, 2017 · 6 comments
Closed

Profiler show text report not working #390

IanTrudel opened this issue Nov 23, 2017 · 6 comments
Assignees
@ccoupe
Labels
FreeBSD
Milestone
3.3.5

Comments

@IanTrudel
Copy link
Collaborator

Show text report hangs Shoes on FreeBSD.
@ccoupe
Copy link

ccoupe commented Nov 24, 2017

BSD does produce unexpected errors. Can you bring up the Shoes log/console - there maybe an error on it. Or small script to call shoes.terminal which is what the text profiler uses.

@IanTrudel
Copy link
Collaborator Author

Opening Shoes.terminal prevents freezing but it will not display anything in an actual terminal nor in Shoes.terminal window. The profiler window shows a button to go back to GUI Display, clicking working.

Opening the profiler from cobbler, running and show text report leads to the following error:

Error in <unknown> line 0 | 2017-11-24 10:48:52 -0500
no implicit conversion of nil into String
/usr/home/ian/.shoes/walkabout/lib/shoes/profiler.rb:330:in `basename'
/usr/home/ian/.shoes/walkabout/lib/shoes/profiler.rb:330:in `block in textscreen'
/usr/home/ian/.shoes/walkabout/lib/shoes/profiler.rb:326:in `stack'
/usr/home/ian/.shoes/walkabout/lib/shoes/profiler.rb:326:in `textscreen'
/usr/home/ian/.shoes/walkabout/lib/shoes/profiler.rb:303:in `call'
/usr/home/ian/.shoes/walkabout/lib/shoes/profiler.rb:303:in `visit'
/usr/home/ian/.shoes/walkabout/lib/shoes/profiler.rb:303:in `block (3 levels) in graphscreen'

@ccoupe
Copy link

ccoupe commented Nov 25, 2017

This does seem to be unique to bsd. Confirmed that it fails. OK on linux. A quick scan of the ruby only provides a suspicion that maybe visit() has broken again . Only a guess.

ccoupe pushed a commit that referenced this issue Nov 26, 2017
for #390 bsd - not fixed but a possible help
ed832c8 
* add option to use the launch terminals stdout/stderr
  instead of Shoes.terminal for text report
ccoupe pushed a commit that referenced this issue Nov 27, 2017
for #390, #389 profiler textscreen improvements
b3a677c 
* does not fix weird bsd error - workaround provided
* can output to a file, the launch terminal, the shoes terminal and the gui
* file output is not colorized (a good thing)
@ccoupe
Copy link

ccoupe commented Nov 27, 2017 •
edited
Loading

I have a workaround since it's a very strange bug. Output to the launch terminal. Might as well output to a file while I'm at it. Could be helpful for #389 test archiving.
profiler

There is a Windows exe beta at the usual place. @backorder will have to build minbsd from branch 'master'.

@ccoupe ccoupe self-assigned this Nov 27, 2017
@ccoupe ccoupe added this to the 3.3.5 milestone Nov 27, 2017
@IanTrudel
Copy link
Collaborator Author

This is great work @ccoupe. It will certainly be useful.

@ccoupe
Copy link

ccoupe commented Jan 13, 2018

Closing. Not perfectly fixed but freebsd only bugs have low priority.

@ccoupe ccoupe closed this as completed Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ccoupe ccoupe

Labels
FreeBSD
Projects
None yet
Milestone
3.3.5
Development

No branches or pull requests
2 participants
@ccoupe @IanTrudel