Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successive Escape Clicks Do Not Trigger Request Close Events #2337

Open
Zambelli24 opened this issue Jan 8, 2025 · 0 comments
Open

Successive Escape Clicks Do Not Trigger Request Close Events #2337

Zambelli24 opened this issue Jan 8, 2025 · 0 comments
Labels
bug Things that aren't working right in the library.

Comments

@Zambelli24
Copy link

Describe the bug

When using a drawer or dialog (this may affect all pop-up style components), if there is a custom behavior added that causes the pop-up to not always close (think Are you sure? type of warnings), successive Escape clicks do not continue triggering the request close events. The escape click works as expected for the first time. After that, the Request Close event is not being trigger by successive escape clicks. Clicking the overlay or close button (X in the top right), will trigger a Request Close every time though.

To Reproduce

Use the codepen below.

Demo

Use this Codepen to see this bug demonstrated for both drawers and dialogs.

Screenshots

N/A.

Browser / OS

  • OS: macOS Sonoma 14.4
  • Browser: Chrome
  • Browser version: 130.0.6723.92

Additional information

I suspect this is related to this change introduced in version 2.13.0. This does not happen in version 2.12.0.

@Zambelli24 Zambelli24 added the bug Things that aren't working right in the library. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

1 participant