JSON highlighting doesn't look right

[flowchartsman]

What version of bat are you using?
bat 0.15.4

Describe the bug you encountered:
Bat does not seem to highlight JSON files very well. Specifically, there's almost no highlighting at all, even though the screenshots would indicate it knows how to highlight keys differently to values in maps.

Describe what you expected to happen?
Something that looks more like the picture on #48

How did you install bat?
homebrew

---

system

$ uname -srm
Darwin 18.7.0 x86_64

$ sw_vers
ProductName: Mac OS X
ProductVersion: 10.14.6
BuildVersion: 18G5033

bat

$ bat --version
bat 0.15.4

$ env

bat_config

bat_wrapper

No wrapper script for 'bat'.

bat_wrapper_function

No wrapper function for 'bat'.

No wrapper function for 'cat'.

tool

$ less --version
less 487 (POSIX regular expressions)

[eth-p]

Yeah, that definitely doesn't look right. And it looks like it hasn't been highlighting JSON properly since the 0.13 release. Specifically, the changes in the Packages submodule pulled in with 7ba5bc7 seem to be the culprit.

---

As a side note, on a light terminal you might be better off using --theme OneHalfLight.

[flowchartsman]

I normally use a dark terminal, these were taken with the vanilla MacOS terminal only to remove any possibility that something in my iterm config was the culprit. And even your 0.12.1 screenshot looks wrong: it's not highlighting anything under GlossDiv

[sharkdp]

Thank you for reporting this!

In order to prevent bugs like this in the future, I'd like to implement what I proposed here: #988 (comment) We should probably open a new ticket for that.

[flowchartsman]

Happy to help. You can count me in on the testing effort. I've been meaning to become more than barely-literate in Rust, and this seems like a good opportunity to expand.

[sharkdp]

That sounds great!

[sharkdp]

@flowchartsman I have opened #1124 to address this. Let's move the discussion to that ticket.

[sharkdp]

Fixed in #1557

[Kabouik]

Except from Monokai, I am experiencing the same issue with pretty much every other bat theme I tried. It's okay for me if at least one dark theme correctly highlights json, but it seems off that the other themes would still suffer from the same issue, so I'm just commenting here in case no one noticed.

[keith-hall]

Thanks for mentioning it, but it's to be expected. We have only patched Monokai, and none of the other color schemes/themes have been updated or patched to color JSON more nicely.