Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent callback execution - sync vs async #206

Open
gkubisa opened this issue Apr 24, 2018 · 1 comment
Open

Inconsistent callback execution - sync vs async #206

gkubisa opened this issue Apr 24, 2018 · 1 comment

Comments

@gkubisa
Copy link
Contributor

gkubisa commented Apr 24, 2018

Callbacks in ShareDB are usually executed asynchronously but in some situations they are executed synchronously, especially when invoked with an error. This is inconsistent and may lead to unexpected behavior in client code. Could callbacks always be executed asynchronously?

See http://blog.izs.me/post/59142742143/designing-apis-for-asynchrony.
@curran
Copy link
Contributor

curran commented Apr 24, 2018

Great call!

Related to the proposal of Promises in #202

This was referenced Jul 24, 2018
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@curran @gkubisa