Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix portfolio balance values #8559

Open
0xApotheosis opened this issue Jan 13, 2025 · 1 comment
Open

Fix portfolio balance values #8559

0xApotheosis opened this issue Jan 13, 2025 · 1 comment
Assignees
@0xApotheosis
Labels
bug Something isn't working

Comments

@0xApotheosis
Copy link
Member

0xApotheosis commented Jan 13, 2025 •
edited
Loading

Overview

Placeholder for grooming - @twblack88 FYI ser

References and additional details

Screenshot 2025-01-13 at 15 45 24

Acceptance Criteria

The numbers shown all make intuitive sense!

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@0xApotheosis 0xApotheosis changed the title Fix portfolio balance displays Fix portfolio balance values Jan 13, 2025
@0xApotheosis 0xApotheosis added bug Something isn't working needs product Requires product input before bounty labels Jan 13, 2025
@0xean
Copy link
Contributor

0xean commented Jan 13, 2025 •
edited
Loading

Possible heuristics

  • if liquid, erc20 like, it should be in wallet
  • if not liquid, IE staked or comes from defi opp it should be shown in the defi section

risks would be around de-duping effectively.

Some assets are token should show up on the defi page, but we only want to include assets in the balance of defi that are illiquid. Still allows the functionality and show up but dont add to the total DeFi balance at the top

@0xean 0xean removed the needs product Requires product input before bounty label Jan 13, 2025
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Jan 13, 2025
@0xApotheosis 0xApotheosis self-assigned this Jan 14, 2025
@0xApotheosis 0xApotheosis moved this from Up next / groomed to In progress in ShapeShift Dashboard Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xApotheosis 0xApotheosis

Labels
bug Something isn't working
Projects
ShapeShift Dashboard
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xean @0xApotheosis