Please provide build instructions without using Android Studio #104
Comments
|
Hey @xrviv, sounds very interesting, I'll try to figure if we can build the project using gradle without any diffs |
That would be awesome! Thank you for the response. |
|
Please feel free to point out if I have some mistakes :) Successful build with this Dockerfile Resultshttps://asciinema.org/a/671137 Yay! I will run a diff tomorrow :) |
|
The diffs: Diff Result for built artifact vs official artifactAfter a successful build, we document the steps we've undertaken and publish an interim merge request. During the initial stages of our analysis, we try to reach out to the developers and inform them of our methodology and the resulting diffs. Differences in build variables, environment or some other cause, may result in a huge diff. If developer outreach is successful, we can collaborate with the goal in making the build reproducible. |
|
Nice! How is the diff from your eyes? As @0xean was the release manager, he might have the build artifact to push in the github releases. If you have a list of strange things you would like us to improve/change, feel free to share it and we'll make sure to add it in our kanban Are you only performing a test on Android or can you also run a new test on the iOS part? Because it looks like the actual rating of the Apple app is wrong because the source file is up, you can still build the app, so we might pass more tests than the old app! |
That would be helpful. The diff is quite big and extensive. But I also noticed that Shapeshift uses AABs and split apks. Can I verify this?
It would be helpful if there is a Dockerfile from you officially. On our end, there is a lot of intuiting what goes to where and what. :) We do not currently verify iOS apps, so, all iOS apps are currently nonverifiable on our end. @Giszmo would best explain the justification, but quick thought: Apple does something. This is a big help and we appreciate it! |
Let's wait then, I see no blockers adding it if the build hasn't been deleted
We are not using Docker to build the app, the workflow is quite old, we are currently manually building the app but we might be able to ease the workflow in the future, unfortunately we are pretty stuck with it for now regarding other priorities :( Also, regarding the current release cycle, I'm not sure this is something we want to invest some time on considering the fact that we are not releasing very often, as you can see in the source code, this app act as a webview entrypoint meaning that the final content is the ShapeShift website even though we have a smallish local wallet handler
Ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello again team Shapeshift.
Danny from Walletscrutiny.com. We verify android apps for reproducibility.
I'm currently trying to build your app using docker in a CLI environment. The README.txt build instructions mentions using Android Studio.
But it would be preferable if I were to build using the terminal. In this way, after the build, we can run a diff or diffoscope on the apks produced and the official apk from Google Play.
We'd appreciate your help on this.
The text was updated successfully, but these errors were encountered: