You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Context
Uncovered! places great importance on accurate card swaps.
Given our customized (and somewhat glitchy) usage of react-beautiful-dnd, the drag-and-drop is not as reliable as we'd like it to be.
Proposed Fix
There's a number of ways to accomplish this, but the most straightforward seems to be:
a modal dialog box asking the player to confirm their swap.
a visual indicator highlighting the cards to be swapped.
The existing code might be moved to another function called when the player clicks the "confirm" button on the modal dialog and the existing onDragEnd handler can instead open the dialog.
The text was updated successfully, but these errors were encountered:
Context
Uncovered! places great importance on accurate card swaps.
Given our customized (and somewhat glitchy) usage of react-beautiful-dnd, the drag-and-drop is not as reliable as we'd like it to be.
Proposed Fix
There's a number of ways to accomplish this, but the most straightforward seems to be:
Relevant Code
The existing code that handles the drag and drop card-swapping is fired when the player releases their mouse or stops their touchpad drag: https://github.com/shaoster/uncovered/blob/master/src/component/PlayerArea.jsx#L18
The existing code might be moved to another function called when the player clicks the "confirm" button on the modal dialog and the existing
onDragEnd
handler can instead open the dialog.The text was updated successfully, but these errors were encountered: