Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Factorio v2.0+ #12

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Caleb-Wishart
Copy link

Update to include API changes for Factorio version 2.0 + Quality

Fixes: #11

CodeGreen0386 and others added 12 commits December 21, 2023 18:19
[FFF-379](https://factorio.com/blog/post/fff-379) should have solved
any issues with ordering, which was the use case for the default select

Updated alt-select to use the new LuaWireConnector interface
Update the item descriptions to reflect the changes to features

de locale was done with google translate, so may not be perfect
Pull in CodeGreen Optimisations
Merge Code Green optimisations
@Caleb-Wishart
Copy link
Author

Includes CodeGreen0386's optimizations in #10

@Caleb-Wishart
Copy link
Author

Fixes #7 (No longer removes poles and tested to work with power switches in 'old' alt-select mode

@Timmarus
Copy link

Timmarus commented Nov 4, 2024

Might be worth forking the repo and creating your own mod on the Factorio mod portal. It seems the original maintainer may no longer be active here.

@Caleb-Wishart
Copy link
Author

Caleb-Wishart commented Nov 4, 2024

Might be worth forking the repo and creating your own mod on the Factorio mod portal. It seems the original maintainer may no longer be active here.

Yea, was going to if they don't reply soon, just wanted to give an opportunity for them to keep the project. They are generally active on GH :)

@shanemadden, will proceed with this plan soon, if you see this after a fork is created feel free to reach out.

@shanemadden
Copy link
Owner

Thanks for the reminder - I've tried to find time the last couple weekends for testing out some updates and getting some of my mods updated, but didn't have the opportunity. I'll take a look and get this merged/released soon (hopefully in the next couple days) but feel free to release a fork in the mean time. And thanks for the PR!

@Caleb-Wishart
Copy link
Author

Caleb-Wishart commented Nov 4, 2024

I'm happy to wait, it's hard to remove a mod from the portal (can only just mark as deprecated).
Anyone who wants to use my fork can download and chuck into their mod folder manually.

Worth noting that this PR will remove a feature.
See 5344b77

Happy to discuss any of the changes I made if clarification is needed.

And no worries on the PR :D
Had the mod dev itch

This commit reintroduces the standard select mode and
reverts the alt-select to the previous behavior.

Selection will now prioritize horizontal and vertical connections,
where this is not possible the smallest possible connection will be made

The tool will also no longer connect two previously unconnected
electric grids.
@Caleb-Wishart
Copy link
Author

@shanemadden,
Following forum discussion Mod Portal: Urgent to Update (and a bit more availability for dev time).

I have recreated the standard connection and added an additional feature.

  • The tool will no longer connect two electric grids that were previously not connected
  • Selection will now prioritize horizontal and vertical connections, where this is not possible the smallest possible connection will be made

It was no longer possible to redo the connections by destroying and recreating the entity as with 2.0 removing a pole will cause the circuit networks to automatically try and compensate. Hence, a new algorithm / policy was required.

I've attached a save that I used for testing if you want to try it on that + some of your bases.

grid-test.zip

Let me know if there is any more I can do to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space Age compatibility
4 participants