Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto unstacking when the player holds a partial stack of stacked items in the cursor slot, and no other stacks in the bag #13

Open
Mernom opened this issue Feb 16, 2020 · 2 comments

Comments

@Mernom
Copy link

Mernom commented Feb 16, 2020

When the player holds a partial stack of stacked items in the cursor slot and picks up stacked items from the same type (while having no other stacked items of that type in the bag), the auto unstacking script will fail to remove the newly picked up items, while succeeding in inserting the unstacked items.

This allows for item duplication, by using Z on top of yourself while also holding F to pick the dropped item up.

@Deadlock989
Copy link
Contributor

I recommend removing or commenting out ownlyme's auto-unstacking code if no-one can see a good fix for this - I can't.

@Mernom
Copy link
Author

Mernom commented Jan 13, 2021

It doesn't seem to hard to fix - add an optional last parameter for 'inventory to insert to', for when it's not identical to the 'inventory to remove from', and then check if there are any stacks of the stacked item in the main inventory.
If there's not, and there are in the cursor inventory, remove from the cursor inventory, and insert into the bag inventory.

I can try wringing that part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants