New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Tor's SOCKS USERNAME/PASSWORD event strings #1

Open

3 tasks

robgjansen opened this issue Apr 16, 2020 · 0 comments

Open

3 tasks

Use Tor's SOCKS USERNAME/PASSWORD event strings #1

robgjansen opened this issue Apr 16, 2020 · 0 comments

Member

robgjansen commented Apr 16, 2020

New enough versions of Tor should already have export a SOCKS_USERNAME and SOCKS_PASSWORD along with circuit control events.

https://github.com/torproject/tor/blob/e3b1e617ae4850280012c95f40e54acdfc897855/src/feature/control/control_fmt.c#L144-L158

We should

verify these value are available in circuit control events
update oniontrace to read those values rather than the USERNAME value from the custom patch in the oniontrace README.
Assuming the above works, we could remove the custom patch from the README.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment