Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min_p sampling crash when using flashinfer backend #3207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix min_p sampling crash when using flashinfer backend #3207

wants to merge 1 commit into from

Conversation

zifeitong
Copy link
Contributor

@zifeitong zifeitong commented Jan 29, 2025 •
edited
Loading

flashinfer backed won't return success states for min_p.

Motivation

Fixes #3201

Modifications

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] min_p_sampling_from_probs() related crashes
1 participant
@zifeitong