Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Removing slash from variable names #4

Merged
merged 4 commits into from
Aug 17, 2020

Conversation

eric-czech
Copy link
Collaborator

@hammer
Copy link

hammer commented Aug 12, 2020

@eric-czech with https://github.com/pystatgen/sgkit/pull/83 in, is this ready?

@eric-czech
Copy link
Collaborator Author

Yep should be good to go now though it looks like we have two issues:

  1. bgen_reader 4.0.5 is no longer compatible with our code (our implementation is using hidden functions that I think @horta removed in Feature request: bulk distributed access limix/bgen-reader-py#30 (comment). I added a version bound on our current dependency for 4.0.4 until we straighten that out.
  2. We need to add zarr as a dependency to work with the vcf_zarr reader in sgkit now. It looks like this should have been added to setup.cfg but it wasn't, otherwise I think this build should still have worked:

I'll file an issue for that and then remove it here later (there's no reason to make zarr a dependency here, I just did that to see what would make the build pass).

@eric-czech
Copy link
Collaborator Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants