From 84432dc94409a3c809daaf1fab2f92782aabba38 Mon Sep 17 00:00:00 2001
From: "D. Smolken" <49921787+DSmolken@users.noreply.github.com>
Date: Sat, 21 Sep 2024 22:20:05 +0200
Subject: [PATCH] Update syntax.yml (#146)

* Update syntax.yml

oscillator_phase range is (any negative value) to 360 in ARIA, 0 to 1 in sfizz - putting -1 to 360 here, like it was before.

* Update oscillator_phase.md

Adding  info about what negative values do in ARIA, and that sfizz is different.
---
 data/sfz/syntax.yml              | 4 ++--
 docs/opcodes/oscillator_phase.md | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/data/sfz/syntax.yml b/data/sfz/syntax.yml
index 2d9100d9a..6d4b56f42 100644
--- a/data/sfz/syntax.yml
+++ b/data/sfz/syntax.yml
@@ -5984,8 +5984,8 @@ categories:
     version: "SFZ v2"
     value:
       type_name: "float"
-      min: 0
-      max: 1
+      min: -1
+      max: 360
 
   - name: "oscillator_quality"
     short_description: ""
diff --git a/docs/opcodes/oscillator_phase.md b/docs/opcodes/oscillator_phase.md
index b8ac54f13..80ba287c0 100644
--- a/docs/opcodes/oscillator_phase.md
+++ b/docs/opcodes/oscillator_phase.md
@@ -2,3 +2,4 @@
 template: "sfz/opcode.j2"
 opcode_name: "oscillator_phase"
 ---
+This opcode behaves in two different ways in ARIA: non-negative values from 0 to 360 set the phase in degrees, while any negative value randomizes the phase. As implemented in sfizz as of version 1.2.3 the range is 0 to 1 which behaves the same as ARIA's 0 to 360.