Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

has_tests has a false negative when a package has tests but does not use a testing package in its Suggests #64

Open
sfirke opened this issue Feb 3, 2022 · 0 comments
Labels

Comments

@sfirke
Copy link
Owner

sfirke commented Feb 3, 2022

For instance data.table has has_tests = FALSE in its results. I don't immediately grasp their CI pipeline but it's complex. Since packagemetrics can find that their test_coverage = CodeCov, I propose that after compiling all info, packagemetrics should check if there's a value for test_coverage, then if so, set has_tests = TRUE. Not a clean solution but a quick one.

Example as of 2022-02-03:

> library(packagemetrics)
> library(dplyr)
> 
> dplyr_and_dt <- package_list_metrics(c("dplyr", "data.table"))
> glimpse(dplyr_and_dt)
Rows: 2
Columns: 17
$ package            <chr> "dplyr", "data.table"
...
$ has_tests          <lgl> TRUE, FALSE
...
$ ci                 <chr> "NONE", "Appveyor"
$ test_coverage      <chr> "CodeCov", "CodeCov"
...
@sfirke sfirke added the bug label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant