Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recently closed issue showing up as NA #63

Open
sfirke opened this issue Feb 3, 2022 · 1 comment
Open

Recently closed issue showing up as NA #63

sfirke opened this issue Feb 3, 2022 · 1 comment
Labels
bug enhancement

Comments

@sfirke
Copy link
Owner

sfirke commented Feb 3, 2022

Running this as of 2022-02-03, I get NA for last issue closed in dplyr repo when it should be 0 days (7 hours ago).

> library(packagemetrics)
> library(dplyr)
> 
> dplyr_and_dt <- package_list_metrics(c("dplyr", "data.table"))
> glimpse(dplyr_and_dt)
Rows: 2
Columns: 17
$ package            <chr> "dplyr", "data.table"
...
$ last_issue_closed  <dbl> NA, 0
@sfirke sfirke added the bug label Feb 3, 2022
@sfirke
Copy link
Owner Author

sfirke commented Feb 3, 2022

Might as well make the unit clear. Right now I think it's days divided by 30? Why not just make it days and call the field days_since_last_issue_closed?

@sfirke sfirke mentioned this issue Feb 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sfirke